Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insticator adapter causing build error #5380

Closed
spenser-roark opened this issue Jun 16, 2020 · 2 comments
Closed

Insticator adapter causing build error #5380

spenser-roark opened this issue Jun 16, 2020 · 2 comments

Comments

@spenser-roark
Copy link

spenser-roark commented Jun 16, 2020

Type of issue

  • Bug

Description

Attempting to download prebid.js with insticator causes an error message, the other bidders I've attempted seem to work fine

Steps to reproduce

  • Select Insticator as a bidder adapter
  • Attempt to download

Test page

  • N/A

Expected results

  • Download prebid.js

Actual results

  • Error message: {"error":"Prebid file not built properly","requestId":"8f46c215-ca50-4f1a-a0bd-9acf964b2c85"}
@spenser-roark spenser-roark changed the title Insticator adaptor causing build error Insticator adapter causing build error Jun 16, 2020
@bretg bretg self-assigned this Jun 22, 2020
@bretg
Copy link
Collaborator

bretg commented Jun 22, 2020

This is an interesting one. 'insticator' was one of the aliases of serverbid, which was not ported to Prebid 3.x as noted in #4650

I don't know specifically what aspect of 3.0 they didn't conform to -- the list is at #4580 - probably related to deprecation of functions in utils.js

Adapters not ported were still left on the Download page while versions of 2.x were still being supported, but we only support the most recent 20 versions of Prebid.js on the Download page, so serverbid and all of it's aliases are now unavailable since no 2.x option can be built there. Note that anyone who wants to build them can still use the command line.

I've gone ahead and removed the following adapters from prebid.org: answermedia, automatad, buysellads, insticator, serverbid. They can be restored if the serverbid adapter is ported or the aliases find another host adapter.

As FYI - adding github accounts that touched the serverbid adapter in 2.x: @Saigredan , @micha , @prebid-pubnx , @jcswart, @jgrimes

@stale
Copy link

stale bot commented Jul 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 6, 2020
@stale stale bot closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants