Bugs in sendBidsControl.dealPrioritization

[jbartek25]

Type of issue

Bug

Description

sendBidsControl.dealPrioritization doesn't work.

Steps to reproduce

Enable sendBidsControl.dealPrioritization and run a HB auction as usual. This will lead to a syntax error:

This can be easily fixed by bucketBids.sort(sortByDealAndPriceBucketOrCpm(true)) in
https://github.com/prebid/Prebid.js/blob/master/src/targeting.js#L47.

However, after applying the fix another error appears:

The problem is that method sortByDealAndPriceBucketOrCpm looks for hb_deal inside adUnitTargeting object which only exists when sortByDealAndPriceBucketOrCpm gets called from within filterTargetingKeys. However, when sortByDealAndPriceBucketOrCpm is called in getHighestCpmBidsFromBidPool, hb_deal is in adserverTargeting object and adUnitTargeting is undefined.

[jbartek25]

Test page: https://test-hb.improvedigital.com/tmp/prebid-deal-issue/issue.html

[ChrisHuie]

closing out with merge of #5504