Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create generalized mock / stub for storageManager #5762

Closed
robertrmartinez opened this issue Sep 16, 2020 · 1 comment
Closed

Create generalized mock / stub for storageManager #5762

robertrmartinez opened this issue Sep 16, 2020 · 1 comment
Assignees
Labels

Comments

@robertrmartinez
Copy link
Collaborator

Type of issue

Test Enhancements

Description

When writing unit tests for modules which use storageManager, we need a better way to mock reading and setting cookies/local storage. As of now, lots of modules are doing it differently.

Relying on browsers in circle ci (and local browsers) to actually set and read back this data is not stable enough for unit tests.

So, we should create a mock which modules can import to their _spec files. Similar to how we mock XHR requests using test/mocks/server.js

See #5758 for the conversations and more details.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant