-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-defined native types: Image not replaced before adapters are called #6389
Comments
@aleksatr @robertrmartinez We discussed this on issue review today, and this seems like a good place to introduce the concept of prebid Native templates with predefined requirements that are then accessed via Shorthand. Aleksa I tagged you until we can add Chris N to prebid, I think he'd find this interesting. |
@guiann this expansion of the shorthand inside of core seems like a great utils function for all adapters accepting native; is there any chance you could take a stab at the function? |
No I've no time to handle it sorry. |
Core now makes the "expanded" type available under Lines 39 to 47 in 0d3f875
Does that solve this issue? |
Seems to |
Hello everyone,
Our bidder supports native ads for a few weeks now and we can see some native bid format with
I would expect this native configuration to be replaced by the full format config specified in:
pre-defined-native-types
Is it expected that bidder adapters receive the short hand format?
That would mean every bidder has to expand every pre-defined types. Duplicating the same code for every bidder and breaking futur integrations when new pre-formated types will be added.
The text was updated successfully, but these errors were encountered: