Pbs bid adapter: video hb_size not returned properly

[ghost]

Type of issue

Bug

Description

There are sizes that returning on video as "undefinedxundefined" on server to server and potentially client side as well. Some bidders choose to send back the playerWidth and playerHeight since sizes are not always returned in the bidresponse. Seems that may Prebid should determine to either filter hb_size when a size is not returned or return the playerWidth and playerHeight as a standard.

Steps to reproduce

Reload page enough time with prebid server and you still see hb_size is not defined properly.

Expected results

I would expect either no hb_size or the size of the actual video.

Actual results

undefined x undefined size or 1x1. Sizes may vary depending on the the adapter or prebid server etc.

Platform details

All version of Prebid.

[gglas]

@mike-chowla we discussed in issue review today -- we think the insertion of undefined is a bug that needs fixing (and it should just be left blank, maybe console log that size is undefined), but wanted to make sure that fix corresponds with the needs in video.

[bretg]

@r-schweitzer - a test page would be good. Do you see the 'undefinedxundefined' in the PBS response JSON or is from PBJS?

[ghost]

@bretg Seems to be related to PBS. I can recreate it on this page https://cafedelites.com/cheesy-scrambled-eggs-in-avocado/. The PBS response doesn't come back with hb_size at all

[bretg]

@r-schweitzer - spent some time with this and can't make it happen. My thought is that PBS targeting variables aren't used by PBJS. They're only used by mobile apps and AMP. So I don't think PBS is the problem here.

There might be some robustness that we can add to the pbsBidAdapter in

Prebid.js/modules/prebidServerBidAdapter/index.js

Line 924 in f50b7ec

let sizes = bidRequest.sizes && bidRequest.sizes[0];

            let sizes = bidRequest.sizes && bidRequest.sizes[0];
            bidObject.playerWidth = sizes[0];
            bidObject.playerHeight = sizes[1];

We should check sizes before accessing them as an array. @ChrisHuie - please make this update?

something like: if typeof sizes is array, then
bidObject.playerWidth = sizes[0];
bidObject.playerHeight = sizes[1];
otherwise, don't set bidObject.playerWidth and bidObject.playerHeight

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dgirardi]

@ChrisHuie the PBS adapter now sets playerWidth / playerHeight to the size that was in the request. Does that solve this issue?

Prebid.js/modules/prebidServerBidAdapter/index.js

Line 972 in 38446e6

[bidObject.playerWidth, bidObject.playerHeight] = [impReq.video.w, impReq.video.h];

[ChrisHuie]

Closing this per pr #7885 ->

Prebid.js/modules/prebidServerBidAdapter/index.js

Line 972 in 38446e6

[bidObject.playerWidth, bidObject.playerHeight] = [impReq.video.w, impReq.video.h];