Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shuffling bidders #703

Closed
eyedar opened this issue Oct 13, 2016 · 6 comments
Closed

shuffling bidders #703

eyedar opened this issue Oct 13, 2016 · 6 comments

Comments

@eyedar
Copy link
Contributor

eyedar commented Oct 13, 2016

I'm starting to hear comments from exchanges like the following:

A round robin would give every network and opportunity at starting first. Although you have a standard timeout, there seems to be a timing issue at times for the the last few networks when they have a high bid. Their high bids are not able to win in the gampad call. Round robin, may alleviate this a bit.

Exchanges seem to believe that not being at or near the top of the bidder array they are at a disadvantage. Is there any merit to this? It strikes me as splitting hairs, but perhaps I'm missing something.

If it is a valid concern, I have implemented a simple bidder shuffling algorithm that might be helpful to the general community (I'm implemented it in response to the above comment). It's not round robin but it takes bid arrays and just randomly shuffles them. If that's of interest to the broader community, I'm happy to contribute it to the code base.

@mkendall07
Copy link
Member

@eyedar
It's valid I think. The reason we didn't implement is because we believed that the publisher should make those kinds of decisions based on what they believe would give them the best monetization. I think having a random shuffle on each requestBids would be nice to have as an option. Can you make PR for it?

@eyedar
Copy link
Contributor Author

eyedar commented Oct 14, 2016

Yes, happy to take a hack at it. Thanks.

@matthewlane
Copy link
Collaborator

@eyedar Any luck implementing this so far? I may start on a similar idea later this week but if you have anything I'll gladly review it

@eyedar
Copy link
Contributor Author

eyedar commented Oct 26, 2016

@matthewlane sorry haven't been able to get to it..I suggest you just go for it at this point...I don't want to hold anything up

@itayo155
Copy link
Contributor

From running some experiments, the concern mentioned above seems to be valid, and more so when there are many bidders and/or the timeout is relatively low. In one experiment with 8 bidders and 700ms timeout, the last bidder was almost never able to respond in time, while the same bidder on the first position had a very high bid-rate.
As for the best way to handle this, I think there should be two options: random order as suggested above; and explicit order settable by the publisher outside of the configuration. The way things are now - (at least as far as I know) - with order settable by changing the bidder order in adUnits, this is both unclear to most publishers, and is easy to break when updating configuration, running a/b tests etc.

@mkendall07
Copy link
Member

This is merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants