-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shuffling bidders #703
Comments
@eyedar |
Yes, happy to take a hack at it. Thanks. |
@eyedar Any luck implementing this so far? I may start on a similar idea later this week but if you have anything I'll gladly review it |
@matthewlane sorry haven't been able to get to it..I suggest you just go for it at this point...I don't want to hold anything up |
From running some experiments, the concern mentioned above seems to be valid, and more so when there are many bidders and/or the timeout is relatively low. In one experiment with 8 bidders and 700ms timeout, the last bidder was almost never able to respond in time, while the same bidder on the first position had a very high bid-rate. |
This is merged to master |
I'm starting to hear comments from exchanges like the following:
Exchanges seem to believe that not being at or near the top of the bidder array they are at a disadvantage. Is there any merit to this? It strikes me as splitting hairs, but perhaps I'm missing something.
If it is a valid concern, I have implemented a simple bidder shuffling algorithm that might be helpful to the general community (I'm implemented it in response to the above comment). It's not round robin but it takes bid arrays and just randomly shuffles them. If that's of interest to the broader community, I'm happy to contribute it to the code base.
The text was updated successfully, but these errors were encountered: