-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make ajax timeout configurable #7382
Comments
Hey @spormeon this is indeed a bit of a vague error, looking at the code there can be a couple of explanations. Given the timeouts, it could be network related, but we can't be certain without a test page -- is there something you could provide that creates the error and would allow us to have a closer look? |
@gglas you on the adops slack channels, rather DM you test pages etc |
I have a test page that returns no-bids doesn't attempt to call /cache. Is this still happening? 'xhr timeout' seems to indicate server or network issue. |
I got the test page from David via AdOps slack and while I don't see the XHR cancelled error, I do regularly see VAST-size errors: adap.tv (via 33across) is returning VAST sizes > 100kB, but AppNexus' Prebid Cache rejects anything more than 40kB. Will bring this up in the video and PBS meetings this week:
|
Here's the Magnite data for entries in PBC of type "xml" 90th Percentile 57224 bytes Based on this, it seems to me that 100kB would be pretty defensible -- it's probably around 98th-percentile. But if a host company didn't want to support the 98th, they could take their pick. I assume that what's most important here from a scaling perspective is the mean size, which is ~23kB. |
was there any word from APN on this? |
Discussed VAST sizing with the video committee. With no additional data, at this point we're planning to post an outline of the above data with a general recommendation for a cache size of 100KB. APN hasn't weighed in yet on whether they're going to change their current limit. |
Here's the Xandr/Appnexus data for the current PBC payload size: 75th Percentile: ~15 KB We're working to see if we can update the size limit and what that new size limit would be. |
any update? |
seeing more and more of these 3secs timeouts again, as well as a size limit is there an actual timelimit as well orf 3 secs, cant this 3 secs be pushed back to 5? |
We discussed this in a recent Prebid Server committee meeting. PBS-Go will change the limit from 40KB pre-compression to something somewhat higher post-compression, As for timeout, I suppose a publisher configurable PBJS client-side caching setting wouldn't hurt. Not clear to me you really want to wait longer because 3 seconds indicates a server-tier problem anyhow. If anything, I would think that pubs might want to lower the default. But that's up to them. Will convert this issue into that enhancement request. |
In ajax.js there's a line with a hard-coded timeout:
|
When will this 40kb limit be removed/extended? |
@spormeon @renebaudisch FYI: The AppNexus limit has bee adjusted to allow 128kb |
i'm seeing this warning, is prebid trying to store to the video cache even when there is no bid or something?
and this error, which i think is related to above but cant 100% tell, is this the error out of the inability to store a "empty" to the video cache?
If i've got this right, shouldn't it just ignore these "empty/ no bids" and NOT try to store in cache?
The text was updated successfully, but these errors were encountered: