Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbsBidAdapter should support adunit.ortb2Imp #7831

Closed
bretg opened this issue Dec 8, 2021 · 3 comments · Fixed by #8159
Closed

pbsBidAdapter should support adunit.ortb2Imp #7831

bretg opened this issue Dec 8, 2021 · 3 comments · Fixed by #8159
Assignees

Comments

@bretg
Copy link
Collaborator

bretg commented Dec 8, 2021

Type of issue

enhancement

Description

To support the app post-bid scenario with OM signaling, we need to allow passing imp.banner.api through to Prebid Server.

Currently, the pbsBidAdapter only looks in ortb2Imp.ext, ignoring other fields in ortb2Imp. This is how the post-bid creative would be specified:

    var adUnits = [
           {
               code: 'test-div',
                mediaTypes: {
                    banner: {
                        sizes: [[728,90]]
                    }
               },
               ortb2Imp: {
                 banner: {
                   api: [7]
                 }
               },
               ...

And for the record, the other parts of OMID signaling are already supported by the pbsBidAdapter with the global ortb2 object:

pbjs.setConfig({
        ortb2: {
          source: {
            ext: {
              "omidpn": "MyIntegrationPartner",
              "omidpv": "1.0"
            }
          }
        }
});

Verification

The test case would be to set AdUnit.ortb2Imp.banner.api:7 and verify that the request to PBS contains that value in imp[].banner.api.

@bretg
Copy link
Collaborator Author

bretg commented Dec 9, 2021

This was discussed in the PBJS committee and approved for development.

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@bretg bretg removed the stale label Jan 12, 2022
@bretg
Copy link
Collaborator Author

bretg commented Jan 25, 2022

This would also support the skadn parameter as described in prebid/prebid-server#1654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants