-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPT Managed OutOfPage ad slots iframe is not resized #7865
Comments
seems to be a partial dupe of #interstitial |
Setting frameElement's style.width and style.height after this sets the correct size:
It doesn't seem to cause any issue / unwanted behaviour at first glance but I'm keen on hearing other opinions. |
It does look like this is a duplicate of #5917. Chris and I discussed and put a suggestion over there. Closing this. @danielguedesb - you can re-open if you disagree that it's a duplicate. |
Type of issue
bug
Description
Using GPT Managed interstitial slots (https://developers.google.com/publisher-tag/samples/display-web-interstitial-ad), prebid's creative is not resized to its expected size, it stays at 1x1 and the ad is not visible.
Steps to reproduce
pbjs.addAdUnits({ code: 'GAM_AD_UNIT_CODE', mediaTypes: { banner: { sizes: [[300, 250], [300,600], [320,480], [336,280], [480,320]] } }, ortb2Imp: { instl:1 }, bids: [{ bidder: 'appnexus' ... }] })
Expected results
Ad Iframe resized to match
hb_size
sizeActual results
Ad Iframe remains at
1x1
but contains width and height attributes with its expected values.I.e. width=300 height=600
Other information
GPT Managed OutOfPage slots render the add inside a second iframe:
ad_slot_div [ id=ad_slot_id_0__container ]
--- Iframe1 [ id=google_ads_iframe_ad_unit_code_0 ]
------ Iframe2 [ id=ad_iframe ]
-------- Prebid Universal Creative code
The text was updated successfully, but these errors were encountered: