Kargo Bid Adapter: meta.advertiserDomains passing incorrectly

[robertrmartinez]

Type of issue

Description

We are seeing scenarios where bid adapters are setting invalid meta.advertiserDomains

This field should be an array of strings

We noticed at least one adapter sending it as an double array with one string in it like so:

[['nytimes.com']]

I am unsure if this is happening ALL of the time for KARGO, or if there are certain scenarions where their server responds with a single adomain or it is always with the array of single element.

They get a bid response from their exchange =>

Notice that it returns advertiserdomains as an array of advertisers (which is exactly what it should be)

BUT their code wraps this inside of another array as seen here:

https://github.com/prebid/Prebid.js/blob/master/modules/kargoBidAdapter.js#L77

Which results in

which is technically not correct!

We found this in our Analytics aggregations so I added a PR for us to handle this for now: #7908

But want to let Kargo know just in case!

[robertrmartinez]

@jsadwith As you were the last person to update the kargoBidAdapter I wanted to let you know this issue we uncovered.

I would update the adapter and tag you in a PR, but I do not know the inner-workings of the kargo adserver so wanted you to check in and make sure how the field in the server response is coming.

Whenever I see it on our pages it looks to always be set as array of strings, so if that is true, the "fix" would be to just pass it along as is and not wrap it in another array.

Let me know what you think!

[jsadwith]

@robertrmartinez Thanks for the note. This is definitely an issue from our end, so I created a PR to remove the extra array - #7910