Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid 6.10.0 doesn't send bidRequest param to floors custom fields #8023

Closed
JulieLorin opened this issue Feb 8, 2022 · 0 comments · Fixed by #8027
Closed

Prebid 6.10.0 doesn't send bidRequest param to floors custom fields #8023

JulieLorin opened this issue Feb 8, 2022 · 0 comments · Fixed by #8027

Comments

@JulieLorin
Copy link
Collaborator

Type of issue

This is a bug

Description

I am using custom schema fields alongside the priceFloors module.
When creating a custom schema field, we create a function that has a bidRequest and a bidResponse as parameters (cf documentation : https://docs.prebid.org/dev-docs/modules/floors.html#custom-schema-fields)
Since Prebid 6.10.0, the bidRequest param is null for bidResponse. (The associated bid request is not sent alongside the bidResponse).

Steps to reproduce

Run an auction with the priceFloors module enabled, some floors defined, with a custom schema.
For example, here is a custom field we use :

connector: (bidReq, bidRes) => bidReq.bidder ?? bidRes.bidderCode

If you have bid responses, you will see an error because bidReq is null.

Expected results

I would exepect to have the bidReq parameter to be filled, as it used to be.
It would be easy to fix it for this example, but we sometimes need the bid request (for example to retrieve a video context)

Other information

It seems to be linked to this commit :
https://github.com/prebid/Prebid.js/pull/7885/files#diff-52e7e567c667b4e2850bccc09785b9d48c3edb905487955df6437d7fc32eb216
The search for a "matchingBidRequest" has been removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant