-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return multiple IDs from same userId submodule #8429
Comments
why not put them all in the ext |
or whhy not just have a single value and multiple decryption keys, one you give each ssp https://crypto.stackexchange.com/questions/39397/one-encryption-many-decryption-keys |
sorry last question, it seems like you already coded up a solution, why not just submit it? |
I don't think we can assume the ext attributes will be the same across partners.
We want to use different IDs so SSPs can only decrypt their own ID and not IDs to other SSPs. This is a business rule already set in place.
I can submit it for review. The solution is not elegant and is coded specific to our own submodule by using the following condition: |
By design, the Merkury platform has siloed identity spaces per SSP and sometimes per-Publisher within the SSP, though that use-case seems to be fading. An individual will have n-number of unique identifiers based on the number of SSPs configured by the Publisher in Prebid. The Merkury module needs to return all of the possible identifiers for an individual, tied to a specific SSP and its unique configuration including per-SSP encryption. |
We have in
We could add a value something like "multiple" or "multiple-encrypted", then have your |
I have some ideas here... I'm thinking about maintaining the current USER_IDS_CONFIG config and checking if the bidRequestUserId passed in is an array, if it is the code will loop through each element and build the EID object based on the sub-module's config as shown below: File: modules/userId/eids.js
Expanding on your idea of having Example eids array.
I think this approach is more in line with how Prebid is already configured to work and structured. I'm going to run this through the test suite and see what breaks and if all goes well I'll submit a PR for review. |
Thanks for the contribution! |
I made some additional changes to construct the eids array for multiple sources as follows:
To make use of this I made changes so the Example config:
I ran it through testing and everything appears to be working with over 80% code coverage. I am preparing a PR for review. |
Overview
We are looking for a way to have our User ID module return different IDs per SSP to consume. The current configuration appears to be limited to a single ID to use by anyone. For our use case each SSP we work with has their own ID to identify users so having a single ID for anyone to use is not possible.
Issue
Each userId submodule is limited to a single configuration, but we are looking for a way to support multiple configurations within our submodule.
Use Case
A publisher would configure to use like this:
Note:
params.ssp_ids
would correspond to their own source and id.Example EID data
The sub-module would construct data similar to the example below. We constructed this data similar to the examples used by
pubProvidedId
, but it can be modified to fit into something more universally acceptable for Prebid.js.Possible Solution
The example below illustrates one possible way to handle multiple source configs.
File: src/modules/userId/eids.js
Sample Test Case
Below is just one example of how something like the above could be implemented into Prebid.js.
Example test/spec/modules/eids_spec.js
The text was updated successfully, but these errors were encountered: