bid adapters: support standard first party data keywords

[bretg]

Type of issue

conforming to standards

Description

While reviewing a documentation PR from (@gchicoye), I noticed that the nexx360 is accepting a 'keywords' parameter and doesn't look for them in ortb2.site.keywords.

It's not acceptable for publishers to have to pass adapters special first party data -- rather, they should be able to set standard FPD keywords and all adapters must read from that conventional location. It's acceptable to support both custom params as well as the conventional location.

Adapters that need to be checked and possibly updated:

• Nexx360
• Appnexus

@ChrisHuie found these additional bidders that need to look into this:

• Craft Bid Adapter
• Winr Bid Adapter
• Pixfuture Bid Adapter
• Mediafuse Bid Adapter
• Beop Bid Adapter
• Displayio Bid Adapter
• Prisma Bid Adapter
• Ras Bid Adapter
• Goldbach Bid Adapter
• Deepintent Bid Adapter
• Sonobi Bid Adapter

[patmmccann]

@bretg does this apply to Xandr adapter?

[patmmccann]

Prebid.js/modules/appnexusBidAdapter.js

Line 846 in 15b688c

if (!isEmpty(bid.params.keywords)) {

[bretg]

It applies to all bidders. @jsnellbaker - please take a look at the appnexus bid adapter to make sure keywords can come from ortb2 and not just bidder-specific params. Thanks!

[jsnellbaker]

To clarify the intent/context, when a publisher specifies ortb2 keywords - they intend to have them apply to all adUnits that were part of the setup? It's not a selective thing per adUnit?

I figure it's the former, but I just want to check in case there are other possible use-cases within the ortb2 setup.

[bretg]

Not clear imp-level keywords is a real use-case, but if it is, seems like AdUnit.ortb2Imp.ext.data.keywords would be the right location.

ORTB specifies site.keywords, app.keywords, user.keywords, and site.content.keywords -- those should be set with setConfig({ortb2}).

[jsnellbaker]

Hi @bretg

Thanks for the feedback. We will take a look into these changes for our next sprint.

[patmmccann]

@jsnellbaker this is complete on your side right?

[jsnellbaker]

left the comment on the wrong issue. Let me review and follow-up

[jsnellbaker]

Yes from what I understand, this should be complete from our end.

[ChrisHuie]

Bid Adapters that take a keyword parameter but don't currently look at either ortb2.site or ortb2.user

• Craft Bid Adapter
• Winr Bid Adapter
• Pixfuture Bid Adapter
• Mediafuse Bid Adapter
• Beop Bid Adapter
• Displayio Bid Adapter
• Prisma Bid Adapter
• Ras Bid Adapter
• Goldbach Bid Adapter
• Deepintent Bid Adapter
• Sonobi Bid Adapter

Bid Adapters that support passing meta keywords but not first party data keywords

Biink Bid Adapter
Adkernel Adn Bid Adapter
The Adx Bid Adapter
Jixie Bid Adapter
Datablocks Bid Adapter
Yieldmo Bid Adapter

[bretg]

This is a possible item for PBJS 8.

Bid Adapters that support passing meta keywords but not first party data keywords

Agree with this. Now that the FPD enrichment is part of core, these adapters should be retrieving meta keywords from core.