Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AD RENDER SUCCEEDED event is misleading #9147

Closed
patmmccann opened this issue Oct 24, 2022 · 2 comments · Fixed by #9195
Closed

AD RENDER SUCCEEDED event is misleading #9147

patmmccann opened this issue Oct 24, 2022 · 2 comments · Fixed by #9195
Assignees
@jlquaccia

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Oct 24, 2022 •
edited
Loading

Type of issue

Potentially documentation issue

Description

We fire emitAdSucceeded event without confirmation that some tracker occurred. We should rename the event or perhaps document extremely well the actual meaning, that the render function did not generate an error.
@patmmccann patmmccann changed the title AD RENDER SUCCCEEDED event is misleading AD RENDER SUCCEEDED event is misleading Oct 24, 2022
@patmmccann
Copy link
Collaborator Author

committee conclusion: this breaking change would have too wide an impact. Let's document exactly what this event means in multiple locations (code comments, docs site)

@patmmccann
Copy link
Collaborator Author

https://github.com/prebid/prebid.github.io/blob/8995668a72b937e6d3755517039a45ec0ac1970d/dev-docs/publisher-api-reference/onEvent.md
https://github.com/prebid/prebid.github.io/blob/6b7688c0557a4399cced277442a655e161cec67b/dev-docs/publisher-api-reference/getEvents.md

@jlquaccia jlquaccia mentioned this issue Nov 2, 2022
Merged
1 task
@jlquaccia jlquaccia self-assigned this Nov 2, 2022
@patmmccann patmmccann linked a pull request Nov 3, 2022 that will close this issue
Prebid Core: Updated Info for adRenderSucceeded Event #9195
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlquaccia jlquaccia

Labels
None yet
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prebid Core: Updated Info for adRenderSucceeded Event jlquaccia/Prebid.js
2 participants
@patmmccann @jlquaccia