Various adapters: tmax bug

[ilapshyn]

Type of issue

Question

Description

If timeout is set on auction level instead of global 'bidderTimeout' and it's lower than default value then some bidders (IX, Sharethrough and others) still send global value as 'tmax'.
Could it affect bidder performance?

Steps to reproduce

global 'bidderTimeout' not set (prebid uses default value 3000)
auction timeout is set to 2500
some bidders still send 3000 in tmax field

Platform details

Version: 7.21

Other information

#8973 - partially mentioned here

[patmmccann]

Each of those adapters has a bug

[patmmccann]

Axonix, beyond, many others

[patmmccann]

Also @TheMediaGrid has this bug, doing incorrect math to find the tmax

[TheMediaGrid]

Also @TheMediaGrid has this bug, doing incorrect math to find the tmax

Hello! @patmmccann Please specify where this bug is? There is a line in our gridBidAdapter where we only use a lower value of timeout. https://github.com/prebid/Prebid.js/blob/master/modules/gridBidAdapter.js#L98

[patmmccann]

Also @TheMediaGrid has this bug, doing incorrect math to find the tmax

Hello! @patmmccann Please specify where this bug is? There is a line in our gridBidAdapter where we only use a lower value of timeout. https://github.com/prebid/Prebid.js/blob/master/modules/gridBidAdapter.js#L98

You should only use the value from the bidRequest, not the lower of the two.

[TheMediaGrid]

Also @TheMediaGrid has this bug, doing incorrect math to find the tmax

Hello! @patmmccann Please specify where this bug is? There is a line in our gridBidAdapter where we only use a lower value of timeout. https://github.com/prebid/Prebid.js/blob/master/modules/gridBidAdapter.js#L98

You should only use the value from the bidRequest, not the lower of the two.

Thank you, fixed - #9339

[patmmccann]

Closing in favor of #9705