Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve FPD enrichment #9335

Closed
dgirardi opened this issue Dec 13, 2022 · 0 comments · Fixed by #9659
Closed

Improve FPD enrichment #9335

dgirardi opened this issue Dec 13, 2022 · 0 comments · Fixed by #9659
Assignees
@dgirardi
Labels
feature

Comments

@dgirardi
Copy link
Collaborator

Type of issue

Improvement

Description

With #9205 prebid will fill in a number of ortb2 fields. The logic should be improved by:

  • merging values set through the "old" setConfig({site, app, device})
  • not filling in more than one of site, app, dooh (related to PBS Bid Adapter : site should not exist when app is present #9258)
  • some values from site, such as publisher should be moved into app (or dooh) when appropriate
  • a number of adapters are filling in device.devicetype. If the logic can be made general, we should move it into core.
@patmmccann patmmccann moved this from Triage to Needs Req in Prebid.js Tactical Issues table Dec 13, 2022
@dgirardi dgirardi mentioned this issue Jan 3, 2023
Merged
1 task
@dgirardi dgirardi moved this from Needs Req to Ready for Dev in Prebid.js Tactical Issues table Jan 30, 2023
@dgirardi dgirardi moved this from Ready for Dev to In progress in Prebid.js Tactical Issues table Mar 13, 2023
@dgirardi dgirardi self-assigned this Mar 13, 2023
@dgirardi dgirardi mentioned this issue Mar 13, 2023
Merged
1 task
@dgirardi dgirardi moved this from In progress to PR submitted in Prebid.js Tactical Issues table Mar 13, 2023
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgirardi dgirardi

Labels
feature
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core: improve FPD enrichment dgirardi/Prebid.js
2 participants
@patmmccann @dgirardi