-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Criteo ID Module: Missing error callback for ajax() cause "g.error is not a function" #9524
Comments
@tbsmark86 can you please add a test page for this issue? |
I don't know what you expect as a test page and I don't know how to configure prebid myself. Wild guess for a test case:
That's somewhat copy&paste from modules/criteoIdSystem.js ~ line 95 |
@allanjun could you take a look? |
Hello @patmmccann |
fixed via #9754 |
Type of issue
Bug. Likely no relevant effect aside from message on browser console
Description
My js bug reporting sees some of these events for real users:
TypeError: g.error is not a function
According to the available stacktrace it's caused src/ajax.js here:
callbacks.error(x.statusText, x);
for some unknown Network reason.
I've found at least one module from my list that uses an ajax() call with an object as argument but only a success callback which is probably the root cause: criteoIdSystem.
I don't know if the module is violating the intended API or if the ajax() call should check if that error callback is available.
Expected results
Handle network error with some simple log entry
Actual results
Uncaught javascript error
Platform details
Prebid 7.35.0 unknown bundle details.
The text was updated successfully, but these errors were encountered: