Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for empty targeting key hb_acat being sent in DFP call #9529

Closed
jlquaccia opened this issue Feb 9, 2023 · 2 comments · Fixed by #9530
Closed

Fix for empty targeting key hb_acat being sent in DFP call #9529

jlquaccia opened this issue Feb 9, 2023 · 2 comments · Fixed by #9530
Assignees
@jlquaccia
Labels
bug

Comments

@jlquaccia
Copy link
Collaborator

Type of issue

Bug

Description

#9217 setup the logic pass along acat, if present with dfp calls. However, the default for hb_acat is being set to an empty string and being sent, hb_acat=. If acat doesn't exist on a page, hb_acat= should not be sent at all.

Steps to reproduce

Test page

Expected results

Actual results

Platform details

Other information

Relates to #9217
@jlquaccia jlquaccia added the bug label Feb 9, 2023
@jlquaccia jlquaccia self-assigned this Feb 9, 2023
@jlquaccia jlquaccia mentioned this issue Feb 9, 2023
Merged
1 task
@bretg
Copy link
Collaborator

bretg commented Feb 13, 2023

@jlquaccia - thanks for reporting this, but can we close this issue since there's a PR open already?

@ChrisHuie ChrisHuie linked a pull request Feb 13, 2023 that will close this issue
Prebid Core: Only Send Optional Category Targeting Key if ACAT is Present on Page #9530
Merged
1 task
@jlquaccia
Copy link
Collaborator Author

@bretg, sure, if the PR for this ticket looks good we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlquaccia jlquaccia

Labels
bug
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
2 participants
@bretg @jlquaccia