-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Module to Detect Ad Slot Visibility for Billing w/ Gpt #9531
Comments
@jlquaccia - this overlaps with several other items that in progress: nurl, burl, loss notifications. As for viewability, we just had to drop a module that was considered insecure. We would like to see a comprehensive approach for this issue that fits these disparate threads. Are you willing to take lead on the requirements here? |
Thanks @bretg, Sure, I would be happy to take on the req's for this one! (Will also be sure to compare against the other proposed tickets as well as I go). Was thinking I could also take on the implementation of the proposal outlined here: #4494 (comment). Would be a separate GH Issue ticket to take on of course, but definitely relates to the intent of this ticket (step 5 on the proposal). Lastly, as for the viewability module that was deemed insecure, was it this one? https://github.com/prebid/Prebid.js/blob/master/modules/viewability.js Was just curious so that I could learn from what may have gone wrong. |
Hey @bretg, sync'd up with some other people at PubMatic today, we were thinking we could combine the logic in the description of this ticket with the bidViewability.js module behind an extra config setting. Since bidViewability is already using gpt and the same gpt event that would be needed. |
Nice. |
Had gotten swept up in work for other tickets in the past couple weeks, but this week I will be able to resume work on #4494 (comment) and the work for this ticket. |
closing as complete #10326 |
Type of issue
Feature Request
Description
#4494 describes adding support for loading an ad and optionally not firing billing notifications. The current proposal to achieve this is outlined in 4494 here: #4494 (comment)
The feature request for this ticket would be to create a new module (called something like "visibilityForBillingGpt"), and enable it behind a setConfig option. The module would perform the following logic:
Other information
#4494
The text was updated successfully, but these errors were encountered: