-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should aliases default to the GVL ID of the main bidder? #9717
Comments
I agree with your proposed guidance
with a slight edit:
|
thanks - wording fixed. |
We probably ought to enhance the bidder documentation with this nuance about when it's ok to share a GVLID - agree? |
absolutely |
There's a related problem that I found working on GPP phase 3: the Prebid.js/modules/appnexusBidAdapter.js Lines 102 to 113 in bb81403
But, it accesses storage using always the same GVL ID: Prebid.js/modules/appnexusBidAdapter.js Line 97 in bb81403
This means that when using for example |
Update on the above: it's not actually a problem, because the GDPR enforcement actually ignores (mostly) the GVLID passed to the storage manager: Prebid.js/modules/gdprEnforcement.js Lines 207 to 212 in bb81403
it's still due some refactoring since the gvlid parameter is misleading - not actually used in most situations, but it's not as urgent as it would otherwise appear. |
we should do log.info (only shows in debug) if someone aliases a bidder and loses gvlid. otherwise, we'll solve the rest with docs on prebid.org |
I'm not as familiar with the
Might be worth noting that PubCommonID is gone in 8.0. Time to switch to sharedid. |
@bretg Thanks. Strange is it was not necessary before, and the module can still access the device and store id and also retrieve. If I set the config, i guess unselecting prebid as vendor in tcf, it will still have access? We are using the sharedid module, I think i noticed some writing that is still calls itself pubcommonid. |
Sorry @bmjoju , have to defer this level of detail to @patmmccann. |
@patmmccann Do you know why this error suddenly comes up?
|
Type of issue
topic of discussion
Description
One of our pubs is running a bidder that is one of the aliases of the appnexus adapter:
What's happening now is that that aliased bidder is not passing GDPR checks because it doesn't declare the GVL ID.
The workaround is easy enough:
But this begs a few questions:
My proposal is that the right approach for Prebid is just what's happening today: the main adapter code should copy their own
gvlid
for aliases where they don't share data. If they share data, then the alias should have either nogvlid
(which should result in failed GDPR validation) or their owngvlid
so users can consent separately.Updated req from discussion: we should do log.info (only shows in debug) if someone aliases a bidder and loses gvlid. otherwise, we'll solve the rest with docs on prebid.org
The text was updated successfully, but these errors were encountered: