MergeConfig fix breaks dspx bid adapter

[muuki88]

Type of issue

bug

Description

The dspx bid adapter is not working in prebid 7.46.0 . I assume the offending line is

Prebid.js/modules/dspxBidAdapter.js

Line 186 in 1ac3572

ttl: config.getConfig('_bidderTimeout'),

because the error we see is this

which I tracked down to this line

Prebid.js/src/adapters/bidderFactory.js

Line 156 in 4f45f15

const COMMON_BID_RESPONSE_KEYS = ['cpm', 'ttl', 'creativeId', 'netRevenue', 'currency'];

and there were no changes on adapter or server response. The only this is the access to the prebid config.

Steps to reproduce

1. use prebid 7.46.0
2. use dspx bid adapter

Test page

Welp.. we fixed it in production by rolling back.

Expected results

dspx works

Actual results

Platform details

• prebid 7.46.0

Other information

• Core: fix spurious warnings on mergeConfig #9704

[patmmccann]

Bad idea to pull ttl for a bid out of user config.

[muuki88]

Yeah. It doesn't make any sense. I'll open a PR next week to set this to a static value.

Anything recommend for bidders that don't provide those server side?

[patmmccann]

300

[patmmccann]

300 is pretty common I'd say, but maybe set it to 60 or something and let them raise it?

[muuki88]

We have a good connection to them and make them aware of the issue. 👍

[dgirardi]

That pattern is wrong in two different ways - it should be bidderTimeout and not _bidderTimeout, but also, bidder timeout has nothing to do with TTL.
Of course, it was copy-pasted into a bunch of other adapters, it's not limited to dspx. @patmmccann - should we fix them all to some arbitrary value like 300?

[patmmccann]

Yes, let's choose 60 and let them increase if they desire.

[muuki88]

Sounds good to me ❤️👍