RTD Module: add getAdUnitTargeting to the auctionEnd event #7872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
1 task
|
@dgirardi ok that sounds good! Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding in the getAdUnitTargeting() call inside the setEventsListeners() method.
Other information
I noticed this function call was removed in: 5989563#diff-6243b20988efe8c84d52352b6115dd25be399540b466384651a51a8eeb937b30L222
If this correct, is there another way setting targeting should be called now?
If not, I am providing this patch in the event this function needs to be added back in here.