Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Make changes to Java version of adapter #1632

Closed
curlyblueeagle opened this issue Dec 14, 2021 · 4 comments · Fixed by #1656
Closed

Question: Make changes to Java version of adapter #1632

curlyblueeagle opened this issue Dec 14, 2021 · 4 comments · Fixed by #1656

Comments

@curlyblueeagle
Copy link

We, at 33Across, would like to recommend making the following changes to our bid adapter. What is the best practice to do so? To have us make a PR or for the Prebid dev team to make them?

  1. Add caller info, like the Go version does. This didn't get ported over?
  2. Rename our adapter from TTX to ThirtyThreeAcross as naming is extremely important to us in terms of bidder recognition from partners.
@rpanchyk
Copy link
Contributor

hi @curlyblueeagle
sorry for long answer. We'll care of your changes.

@curlyblueeagle
Copy link
Author

@rpanchyk so I have already made the changes in my fork. Can I make a PR against your repo?

@rpanchyk
Copy link
Contributor

ah cool, sure - go ;)

@curlyblueeagle
Copy link
Author

thanks! I will file the PR after the holidays as we don't want to make any new releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants