-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid Server Price Floor Feature #1162
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not really specified above, but my feelings towards account scope data is as follows: For options that are controlled by the publisher or by the PBS host's business logic, it is best to use an object stored directly in the request, and have that data filled in by the stored request backend. That will then hook the configuration into the existing publisher config system rather than adding a second location where some publisher configs will live. For options that the PBS host will need to control directly without option for the publisher to override (for example account white/blacklists), PBS configuration option rather than request object. So for the above flags, I would recommend all the flags be settable in the request, which would by default allow all of them to be auction specific in theory, while the stored request solution could limit some to an account level setting. At least outside of a publisher overriding what the stored request system supplied using a properly crafted request. |
Is the list of supported fields for floor schema final? For example, the examples contain "impId" and "imp.id", but none is explicitly listed there. Additionally, are the values case-sensitive? If so, can we print them explicitly? Is there an expected resolution algorithm when multiple keys are match? First wins, last wins, most specific wins... |
@hhhjort Thank you, i added better definition in the description to keep context of host-wide flags or stored request level flags. If you have any feedback, I am open to suggestions.
The list is not final. This is simply in the intent to implement phase and has not started. The idea is to make the system flexible to fit most use cases. In this first pass we wanted to start with some basic fields that made sense. We didn't want to overload the development from the start.
no. Following what we are doing in js, all rules and processing should be treated as lower case, even if sent as upper case. I added that requirement as point 24.
See point 20 in the requirements for the list of defined supported fields. I left out impId. Thanks for the heads up.
The idea here is that there should not be two matches. The floor provider (or publisher if setting rules manually) should avoid having duplicate rules. It is impossible for rules to collide if they are all unique. For non-unique rules, the behavior would be unexpected results. |
Note that this feature should be implemented using the Modularity architecture #1734 |
Hi @bretg, |
@pm-jaydeep-mohite - the PBS-Java team is testing the floors feature. It turns out we were unable to implement it as a module due to some of the specific requirements of floors. It's a pretty complicated feature as you can see from the PRD. It's taken several months to build. No one has signed up to build this feature in PBS-Go yet. I'd suggest waiting until it's released in Java for you to consider porting to PBS-Go -- that would likely reduce the implementation time. |
Floors are live in PBS-Java as of 1.87 |
Hello! Are floors also live in PBS-go ? Can this be closed ? Thx |
Good call @afewcc - this was indeed done in PBS-Go by the Pubmatic team last year over a series of PRs. Closing. |
Overview
The document describes the Prebid Server implementation of the Price Floor Feature as defined here. Prebid Server will contain its own set of requirements given the additional flexibility PBS has to execute code in a server-side environment.
Intended workflow will remain the same in PBS as in pbjs:
PBS should support Prebid.js, Prebid Server, and Prebid SDK.
Please see the Product Requirements Document (PRD) for detail.
The text was updated successfully, but these errors were encountered: