Prebid video - Override parameters inside createImpressionTemplate

[neririchter]

It seems that when using stored imps, the function of: "createImpressionTemplate" inside Video_auction class overrides all parameters except a few params:

func createImpressionTemplate(imp openrtb.Imp, video *openrtb.Video) openrtb.Imp {
imp.Video = &openrtb.Video{}
imp.Video.W = video.W
imp.Video.H = video.H
imp.Video.Protocols = video.Protocols
imp.Video.MIMEs = video.MIMEs
return imp
}
but if I wish to use for example Imp.video.playbackmethod or any other video parameters i can not.
not from the stored imps and not from the request itself, because its been override.

[SyntaxNode]

Can you please take a look at this?
@camrice @jmaynardxandr @VeronikaSolovei9

[VeronikaSolovei9]

Initial bug fix PR: #1297
Please note, we don't support stored impressions in video endpoint. The only way to pass data is request body.
According to specification we only expect those 4 params in video object. This fix extends video data to all data we have in openrtb.Video object.
@SyntaxNode @camrice @jmaynardxandr

[neririchter]

I am a bit confused when you say we don't support stored impressions in video endpoint, because if I take a look at the server documentation I am required to create pod configId that is a stored imp, and as part of the stored imp, an empty video object is been stored.
and I understand we must validate those 4 params but we can not block other openRtb params coming from the request to pass to adapters.

[VeronikaSolovei9]

@neririchter pod id is a config id where we store only extension part of impression(in most cases bidder related parameters), not the entire impression. Video object validation is now happening in validateVideoRequest function and it validates only MIMEs and Protocols. Video.W and Video.H are optional. I agree, passing other video related parameters make sense.

[neririchter]

@VeronikaSolovei9 understood, thank you for the detailed response.

[SyntaxNode]

@neririchter Does PR #1297 resolve all of your concerns? If so, can we please close the issue?

[neririchter]

@SyntaxNode yes, thank you, this PR, resolve all my concerns