Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid Server Adding an SChain node #1491

Closed
bretg opened this issue Sep 11, 2020 · 3 comments
Closed

Prebid Server Adding an SChain node #1491

bretg opened this issue Sep 11, 2020 · 3 comments

Comments

@bretg
Copy link
Contributor

bretg commented Sep 11, 2020

We haven't actually been asked for this yet, but I predict that someday someone's going to want to have Prebid Server add an schain node to an existing list in source.ext.schain.

Currently, PBS-Go can support initializing the schain with the default server request, but neither version has the ability to add a node to the end of an existing list.

The proposal:

  1. Add a new optional server-level config that lets the host company define an schain node.
  2. If this config is specified and is valid:
    2a. If source.ext.schain doesn't exist, the configured schain node is added there as the first element in the node array
    2b. If source.ext.schain does exist, the configured schain node is appended to the end of the node array

e.g.

auction:
    host-schain-node: '{ "asi":"pbshostcompany.com", "sid":"00001", "rid":"BidRequest", "hp":1 }'

Would get added to the end of source.ext.schain.nodes:

  "source": {
    "ext": {
      "schain": {
        "ver":"1.0",
        "complete": 1,
        "nodes": [
          {
            "asi":"firstschainnode.com",
            "sid":"00001",
            "rid":"BidRequest1",
            "hp":1
          },
          { "asi":"pbshostcompany.com", "sid":"00001", "rid":"BidRequest", "hp":1 }
        ]     
      } 
    }
  }
@SyntaxNode
Copy link
Contributor

We haven't actually been asked for this yet,

Shouldn't we wait until we discover a need to implement such a feature?

@AlexBVolcy
Copy link
Contributor

This issue is now being worked on by me! I expect a PR to be out early next week.

@AlexBVolcy
Copy link
Contributor

This feature has been implemented and merged in, and will be released in PBS-Go v0.217.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants