Make /info/bidders endpoint consistent between Go and Java

[bretg]

As discussed in PBS committee, there's currently a difference between PBS-Go and PBS-Java in the /info/bidders endpoint.

• PBS-Go lists all bid adapters whether or not they're enabled
• PBS-Java lists only enabled adapters

As both use cases are useful, the proposal is to add a query string parameter (?enabledonly=true/false). This value has no default and will return HTTP 400 if not provided with body "missing enabledonly flag"

The results of the /info/bidders/BIDDER endpoint should include all the fields currently in the PBS-Go output:

{
    "status": "ACTIVE",
    "usesHttps": true,
    "maintainer": {
        "email": "scope.sspp@adform.com"
    },
    "capabilities": {
        "app": {
            "mediaTypes": [
                "banner",
                "video"
            ]
        },
        "site": {
            "mediaTypes": [
                "banner",
                "video"
            ]
        }
    }
}

[SyntaxNode]

Sounds good to me. What should the behavior be if enabledonly parameter is not either true or false? Perhaps we should use the default, or another option is to return an error.

[SyntaxNode]

Discussed with a few other folks. We currently prefer to validate enabledonly and return an error if it's not true or false, case insensitive.

[bretg]

this was released with PBS-Java 1.71

[SyntaxNode]

I implemented this for PBS-Go, but noticed the specifications had since changed to return a 400 if the new enabledonly parameter is not provided. This is a breaking change which will affect folks at Xandr. To avoid problems for existing usages, I will have enabledonly default to false for PBS-Go.

[bretg]

This is ok @SyntaxNode , but the spec changing was due to your request from April 7th. :-)

[SyntaxNode]

Ah! I see. In that case I believe this is a misunderstanding. I didn't intend to make it required, but to validate the parameter only when its provided, such that:

/info/bidders -> all bidders (backwards compatibility)
/info/bidders?enabledonly=false -> all bidders
/info/bidders?enabledonly=true -> enabled only
/info/bidders?enabledonly= -> 400 error
/info/bidders?enabledonly=foo -> 400 error

[SyntaxNode]

Implemented in PBS-Go 0.177.0.