-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid version in an HTTP header #1818
Comments
Prebid SDK will be passing environment as well: |
Please hold off on this update -- it caused major problems in Prebid.js. |
Hi team, I'd really love to make sure MediaGrid could support reading the PBS version. Any insights on the right param for us to be reading this from? |
Updated the proposal to drop the header supplied by PBJS. Since it was a browser CORS thing that prevents the header, we believe it's still acceptable in server-to-server communication. Will discuss in the next committee meeting. |
Discussed in committee. We need to consider the difference between the "integration" vs this ext.prebid.version proposal. Also discussed whether we might need to make an opt-out on the new header. Looking for community input on this. Suggestion is to make it a global behavior flag initially until we learn whether we need a per-bidder flag. |
Updated the proposal to not use ext.prebid.version, but rather ext.prebid.channel: {name: "pbjs", version: "4.39"}. |
Updated the proposal to have PBS prepend ext.prebid.channel to x-prebid if it's specified. |
@bretg does this mean that we would always get the PBS version in ext.prebid.channel if supported by the tech layer? (xandr, magnite, etc) |
Prebid SDK already sends the version to PBS in the
Rather than having to change the location of where Prebid SDK passes data, can we have PBS read the signal read from these existing locations? |
Released with PBS-Java 1.67 |
Hey everyone, I'm working on this issue in #1981 and would like your input on one case (raised in #1981 (review)): If the binary doesn't have access to the version variable (if it's not built with the correct flag) I think it's best to note in the header that it came from pbs-go, so the version record would be |
@rokostik - yes, the 'unknown' edge cases you mention are fine.
|
Implemented in PBS-Go 0.177.0. |
Type of issue
Proposed Enhancement
Description
The Prebid Server side of prebid/Prebid.js#6627
There's interest from some bidders to be able to cleanly distinguish the source of traffic. Currently it's up to each bidder to read the version and pass it to their endpoint. There aren't any conventions about where bidders should place this version, so they've probably done it in various ways.
The proposal is to update PBS to add/modify a new HTTP header
x-prebid
which carries the PBS version:The Prebid.js team attempted to implement this header, but ran afoul of a browser CORS check -- it causes a pre-flight OPTIONS check, which is not acceptable. So instead, the proposal is to have the PrebidServer BidAdapter put the PBJS version in ext.prebid.channel: {name: "pbjs", version: "4.39"}.
This value should be made available to bid adapters who want to know the version of PBJS that initiated the request.
It's assumed that PBS can still add an HTTP header, but we should find a way to test this.
Prebid Server creates the header
Prebid Server creates the header, prepending the name and version from ext.prebid.channel.{name/version} if it exists:
SDK
The SDK already sends the version in app.ext.prebid::
PBS should read app.ext.prebid and if present, add the source/version to outgoing HTTP headers.
The text was updated successfully, but these errors were encountered: