Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Bid Metadata #1871

Closed
bretg opened this issue May 28, 2021 · 2 comments
Closed

Support Bid Metadata #1871

bretg opened this issue May 28, 2021 · 2 comments

Comments

@bretg
Copy link
Contributor

bretg commented May 28, 2021 •
edited
Loading

We got a question about bid metadata from PBS. Looking into the 3 code bases, there are inconsistencies in this area:

  1. PBS-Go asks adapters to put bid metadata in bid.ext.prebid.meta.ATTR
  2. PBS-Java docs say to put it in bid.ext.ATTR
  3. The PBJS PBS bid adapter is looking for only two attributes: bid.ext.dchain and bid.adomain

Proposal:

  • settle on bid.ext.prebid.meta.ATTR. (where ATTR is camel case with the first character being lower case)
  • update PBJS pbsBidAdapter to copy all fields in bid.ext.prebid.meta.ATTR to the resulting "bidObj.meta".
  • Remove bid.ext.prebid.meta.AdvertiserDomains from the PBS documentation. Server-side bid adapters should use bid.adomain
  • Update the developer docs to drop the note that bid.ext.prebid.meta.mediatype should match bids.BidType
@bretg
Copy link
Contributor Author

bretg commented Jun 1, 2021

docs PR prebid/prebid.github.io#3002

@bretg bretg mentioned this issue Jun 2, 2021
Closed
@bretg
Copy link
Contributor Author

bretg commented Jun 24, 2021

PBJS pbsBidAdapter updated with 4.43

@bretg bretg closed this as completed Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bretg