Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie_sync - prefer iframe over pixel when both are available #1971

Closed
bretg opened this issue Aug 20, 2021 · 5 comments
Closed

Cookie_sync - prefer iframe over pixel when both are available #1971

bretg opened this issue Aug 20, 2021 · 5 comments
Labels
PBS-Java Ready For Dev Feature specification is ready to be developed.

Comments

@bretg
Copy link
Contributor

bretg commented Aug 20, 2021

We got a request from a publisher that Prebid Server should be able to prefer iframe syncs over redirect syncs. Currently the choice of which is used is based on the order of the configuration per-bidder.

A better solution would be to have the /cookie_sync endpoint prefer iframes when both are available and allowed. I can't imagine that many pubs or bidders would prefer redirects when both are allowed.

@SyntaxNode
Copy link
Contributor

If we change PBS to always prefer iframe, that would remove a feature we have today where bidders decide in their user sync config which endpoint takes precedence if both are available.

I like what @hhhjort suggested in the PMC meeting, to give this option to the publisher.

We could implement a preferiframe bool or a more generic prefer string enum with values of iframe and redirect. This could be an argument to /cooke_sync and also included in the server side account config.

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@bretg bretg removed the stale label Jan 21, 2022
@SyntaxNode SyntaxNode added the Intent to implement An issue describing a plan for a major feature. These are intended for community feedback label Jan 21, 2022
@SyntaxNode
Copy link
Contributor

Discussed and decided at the Prebid Server Committee to remove the adapter default configuration and hardcode it to iframe. All adapters have so far chosen iframe as their default so there is no negative impact or breaking changes.

Publishers may continue to use filters on user sync requests to define their preference for iframe or redirect.

@SyntaxNode
Copy link
Contributor

Implemented in PBS-Go 0.205.0.

@SyntaxNode SyntaxNode added Ready For Dev Feature specification is ready to be developed. and removed enhancement Intent to implement An issue describing a plan for a major feature. These are intended for community feedback labels Sep 7, 2022
@bretg bretg removed the projectboard label Sep 8, 2022
@bretg
Copy link
Contributor Author

bretg commented Sep 30, 2022

Closing this, as it will be done soon with #2173

@bretg bretg closed this as completed Sep 30, 2022
Repository owner moved this from Triage to Done in Prebid Server Prioritization Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PBS-Java Ready For Dev Feature specification is ready to be developed.
Projects
Status: Done
Development

No branches or pull requests

2 participants