-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listen to unix socket instead of tcp ? #2147
Comments
@matthieularere-msq - can you please elaborate on this request?
Sounds like you have a server running on the same box and can assume a same-box connection to PBS? |
Indeed, it's a same-box connection to PBS. |
One of the engineers will have to weigh in on whether there's much work to support HTTP2 inbound for PBS-Go and/or PBS-Java. That seems like the easiest approach here, IMO. |
@matthieularere-msq So you are looking to use HTTP over Unix Sockets? There is not currently an option to listen on Unix Sockets, but I don't see a reason why not to give the Host an option. Are you interested in putting up a PR for this? I found an example here for how to bind to Unix Sockets in Go. Looks simple. The appropriate place to implement this in PBS-Go is: prebid-server/server/server.go Line 96 in 2ac9d20
You would need to pass the configuration down to those calls (one for admin endpoints and another for the main endpoints). Are you using Prometheus? I haven't looked into how to add Unix Socket support on that endpoint. I'm also cool with using HTTP2. I think PBS-Go already has support for HTTP2 incoming connections if you'd like to give it a try. |
@SyntaxNode Thanks, I'll try to see if I manage to make unix socket work, if so I'll submit a PR. I've tested pbs-go with http2 but it's not supported:
|
Implemented in PBS-Go 0.208.0 by community contributor @mediasquare-alexandre. To use this feature, set the |
@bretg Does PBS-Java plan on adding a similar feature? |
Maybe VertX already supports it. Adding @SerhiiNahornyi to confirm |
Done in PBS-Java 1.91 |
Is there currently a way to make prebid-server listen to a unix socket instead of tcp port ? My prebid-server isn't exposed but behind a app acting as a proxy to build the openrtb request send to prebid-server, so using unix socket could avoid me to reach tcp limits.
The text was updated successfully, but these errors were encountered: