-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing oRTB.site.domain when no http referer is provided #2300
Comments
PBS-Java sets site.domain and site.publisher.domain: site.domain: full domain. e.g. www.example.com. or sports.usatoday.com We'll review how these values are set and make sure it's in sync with Go |
PBS-Go current logic:
Note: we never set PBS-Go logic with proposed change:
Note: for Also, |
I've opened an internal ticket to have the PBS-Java team investigate and align Java to this approach. |
FWIW, happened to run a test comparing PBS-Go and PBS-Java output. Here's the outcome regarding domains. Referer: https://www.britannica.com/event/Seven-Years-War/Preliminary-negotiations-and-hostilities-in-the-colonies
I believe the PBS-Java results are correct:
PBS-Go hasn't been updated:
|
👍 The original problem description has been implemented but PBS-Go still needs to set |
@AlexBVolcy Thanks for working on this. I noticed that PBS Go currently sets |
Hi,
While checking the Prebid server integrations on several sites, we've noticed an issue with 'no-referrer' meta tag.
The /auction endpoint is currently checking the following values in bid request:
If any of them is not presented, then the Http.Referer header is parsed and the results are passed to the 'Site' object:
https://github.com/prebid/prebid-server/blob/master/endpoints/openrtb2/auction.go#L1525
Sometimes the publishers use the following meta tag on the sites - it prevents browsers from sending Http.Referer to any requests:
<meta name="referrer" content="no-referrer">
If the 'site.domain' is also missing in the bid request payload, then it won't be parsed and passed to the adapters.
Example request below:
So, the final request to /auction enpoint:
We suggest to parse the Site.Page - if Http.Referer is empty and Site.Page is available - to extract the Site.Domain value.
The text was updated successfully, but these errors were encountered: