Sovrn Adapter has a type mismatch with the bidfloor parameter

[premesh]

If the bidfloor parameter is used as defined in the prebid.js docs but sent to PBS you get the following error message

Looks like the PBS Java Sovrn Adapter is looking for a number
https://github.com/prebid/prebid-server-java/blob/70f5b9ad65796559d3ff884fe917dd41bfaa786b/src/main/resources/static/bidder-params/sovrn.json#L15

While the PBJS Sovrn Adapter expects a string
https://docs.prebid.org/dev-docs/bidders/sovrn.html

[bretg]

@ikagotso - can you take a look at this? The best solution, IMO, is to remove the bidfloor parameter entirely. Your adapter should be using the Prebid Server-wide floors feature.

[bretg]

Note, this is also a string in PBS-Go https://github.com/prebid/prebid-server/blob/master/static/bidder-params/sovrn.json

[SyntaxNode]

Friendly ping @ikagotso, have you had time to look at this issue?

[ikagotso]

@SyntaxNode
We have started discussions around this.

[ikagotso]

We have opened a PR with a fix.

[ikagotso]

PR to fix this is already merged.

[bretg]

Which PR was is @ikagotso ? I don't see it either PBS-Go or PBS-Java repo

[ikagotso]

@bretg
prebid/Prebid.js#11208

[bretg]

Thanks @ikagotso -- that may be helpful in the long run, but publishers don't upgrade Prebid.js often so the mismatch is going to persist for years in the wild. You're going to want to update your server-side adapter accept either string or number since Prebid Servers are upgraded much more frequently by host companies.

This can be done in in the JSON file https://github.com/prebid/prebid-server/blob/master/static/bidder-params/sovrn.json and by writing a unit test to make sure the adapter itself handles the scenario.

[bretg]

@ikagotso - this is still an issue in both PBS-Go and PBS-Java. Please fix your adapter:

1. Remove the bidfloor parameter entirely.

OR

1. Update the parameter schema to accept bidfloor as either string or number
2. Update adapter to convert the bidfloor to whatever your endpoint expects

[ikagotso]

@bretg
Sorry for delay. We will start working on the fix in a short while.