Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about endpoint #3538

Closed
krdzo opened this issue Feb 23, 2024 · 2 comments
Closed

Question about endpoint #3538

krdzo opened this issue Feb 23, 2024 · 2 comments

Comments

@krdzo
Copy link

krdzo commented Feb 23, 2024

Hello.
We want to add new adapter to PBS. Our bidding server works by having a different endpoint for app and site requests.
The adapter will support both site and app requests but we would like to have a dynamic URL that depends on the type of request we received.
The url will be something like https://{{.HOST}}.bidding-server.com/openrtb2/ where {{.HOST}} will be changed by app or web depending on which field is populated request.App or request.Site.

Can we do something like this in our adapter or is this not allowed?

@bretg
Copy link
Contributor

bretg commented Feb 23, 2024

@krdzo - Given that you were kind enough to ask this question, you might be aware of the conversation at #2612 (comment)

The part about dynamic hostnames that bothers us is the unlimited nature -- one adapter could force PBS to do thousands (millions) of DNS lookups if it depends on a request parameter that can be abused.

But if I understand it correctly, what you're asking for here is exactly 2 DNS names. Something like:

https://site-reqs.bidding-server.com
https://app-reqs.bidding-server.com

Assuming this is coded in such a way that the adapter strictly controls the existence of exactly two endpoints, this would be fine.

@krdzo
Copy link
Author

krdzo commented Feb 23, 2024

@bretg Thank you for the answer, I tried to search trough the issues but missed the one that you linked.

Yes you understood this correctly. We will only have two endpoints and they will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants