-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible Data Leakage Through AMP Load Cookie iFrame #490
Comments
That's a really good catch! @jaiminpanchal27, @mkendall07, @jsnellbaker ... thoughts? |
it looks like AMP is integrating some kind of consent framework. We'll need to look into that and see if it's possible to pass consent data into PBS. ampproject/amphtml#13716 |
@mkendall07 I dove through AMP a bit to understand the Here are some highlights:
|
@gramorris I'm not a GDPR expert, so... a question about this:
I thought that GDPR required users to give their consent to each company who wanted to use their personal info. If we added query string param support for bidders, how would the publisher setting up their AMP page know which bidders the user had consented to? |
Yeah you're right, that doesn't satisfy GDPR. On the consent flags in the amp implementation I don't think that's fit for purpose yet. We've just got to the testing stage now but I don't think there's the ability (there should be and hopefully will be) to get optional consent for multiple vendors and have separate consent flags for each. Google are selling the AMP solution so I'm assuming they intend to have it complete at some point. |
Actually... I may have spoken too soon here. This Issue is making sure that The amp-consent docs say that the tag only supports a single
All that in mind: it seems like their strategy is for publishers to use a single Consent instance/UI, and list all the vendors who they plan to share data with in their consent modal. If that's all accurate, then it seems like we could pass query strings, the way you suggested. You could do the following
And then make sure that the We could enhance |
I was researching stuff for #501 (similar issue in non-AMP pages), and found that the IAB defines a spec for CMPs. These manage consent data across pages, and have some standards for use in iframes: If there's some way to load your CMP onto an AMP page and we can find a way to get the consent info into it, this would be a much better solution. |
@dbemiller, Vamsee from the AMP team here.
This is exactly the assumption under which is currently developed. Having said that we are looking at supporting per vendor, per purpose based consent post May 25th if that's something publisher absolutely request. |
@jasti Thanks for the details Vamsee. I did a bit more research, and I don't think AMP's localstorage scheme will integrate well with the IAB's So... I don't think it's possible for publishers using the Prebids to be able to share the user's consent between AMP and non-AMP pages. All that in mind, I logged prebid/prebid-universal-creative#19 to add the query params and update the AMP docs. Once closed, publishers will need to update their Since Prebid Server's @gramorris please close this and follow prebid/prebid-universal-creative#19 if you feel like this sufficiently addresses your concerns. |
Thanks I'll close this, in the immediate term with the amp-consent limitations I'd accept this as the solution. We have a non-optimal solution to ensure we have some level of consent on AMP pages. |
Just checking on this. It seems that the AMP Cookie Sync iFrame is loading against all possible bidders irrespective of whether they're being used on the page. In the two examples below e-planning and conversant are dropping cookies despite not being bidders.
This would breach GDPR where the data is neither being used and presumably consent would not have been received to do this.
I don't know if it's possible but it would seem that the possible solution may be to pass bidders through to the cookie sync in url vars. If my observations are correct.
The text was updated successfully, but these errors were encountered: