Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current LTTB (lttbc) algorithm is sometimes numerically unstable #93

Closed
jvdd opened this issue Jul 1, 2022 · 2 comments
Closed

Current LTTB (lttbc) algorithm is sometimes numerically unstable #93

jvdd opened this issue Jul 1, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@jvdd
Copy link
Member

jvdd commented Jul 1, 2022

There appears to be (very minor) changes in floating point numbers when using the lttbc LTTB implementation

This causes test test_fwr_time_based_data_s to fail sometimes

A fix for this would be using our own lttb algorithm (also implemented in C) -> see #84

As for now, we will disable this test (as this only occurs in very niche use-cases) and leave this issue open until this problem is resolved (by merging #84)
@jvdd jvdd added the bug Something isn't working label Jul 1, 2022
@jvdd jvdd mentioned this issue Jul 1, 2022
Merged
14 tasks
@jonasvdd
Copy link
Member

shoulde be resolved by merging #103

@jonasvdd
Copy link
Member

jonasvdd commented Jul 17, 2022 •
edited
Loading

Will be fixed in a new release with #103

@jvdd jvdd mentioned this issue Jul 17, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvdd @jonasvdd