Update installation Instructions

[jayceslesar]

I am able to install this as a dependency but I cannot pip install -e . inside of a virtual env

❯ pip install -e  .
Obtaining file:///Users/jslesar/projects/tsdownsample
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... done
  Preparing editable metadata (pyproject.toml) ... done
Collecting numpy
  Using cached numpy-1.24.1-cp310-cp310-macosx_11_0_arm64.whl (13.9 MB)
Building wheels for collected packages: tsdownsample
  Building editable for tsdownsample (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building editable for tsdownsample (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [60 lines of output]
      Running `maturin pep517 build-wheel -i /Users/jslesar/projects/tsdownsample/venv/bin/python3 --compatibility off --editable`
      📡 Using build options bindings from pyproject.toml
      💻 Using `MACOSX_DEPLOYMENT_TARGET=11.0` for aarch64-apple-darwin by default
         Compiling argminmax v0.3.1
      error: could not compile `argminmax` due to 7 previous errors
      💥 maturin failed
        Caused by: Failed to build a native library through cargo
        Caused by: Cargo build finished with "exit status: 101": `"cargo" "rustc" "--release" "--manifest-path" "/Users/jslesar/projects/tsdownsample/Cargo.toml" "--message-format" "json" "--lib" "--" "-C" "link-arg=-undefined" "-C" "link-arg=dynamic_lookup" "-C" "link-args=-Wl,-install_name,@rpath/tsdownsample.cpython-310-darwin.so"`
      📦 Including license file "/Users/jslesar/projects/tsdownsample/LICENSE"
      🍹 Building a mixed python/rust project
      🔗 Found pyo3 bindings
      🐍 Found CPython 3.10 at /Users/jslesar/projects/tsdownsample/venv/bin/python3
      error[E0554]: `#![feature]` may not be used on the stable release channel
       --> /Users/jslesar/.cargo/registry/src/github.com-1ecc6299db9ec823/argminmax-0.3.1/src/lib.rs:1:1
        |
      1 | #![feature(stdsimd)]
        | ^^^^^^^^^^^^^^^^^^^^
      
      
      error[E0554]: `#![feature]` may not be used on the stable release channel
       --> /Users/jslesar/.cargo/registry/src/github.com-1ecc6299db9ec823/argminmax-0.3.1/src/lib.rs:2:1
        |
      2 | #![feature(avx512_target_feature)]
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      
      
      error[E0554]: `#![feature]` may not be used on the stable release channel
       --> /Users/jslesar/.cargo/registry/src/github.com-1ecc6299db9ec823/argminmax-0.3.1/src/lib.rs:3:1
        |
      3 | #![feature(arm_target_feature)]
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      
      
      error[E0554]: `#![feature]` may not be used on the stable release channel
       --> /Users/jslesar/.cargo/registry/src/github.com-1ecc6299db9ec823/argminmax-0.3.1/src/lib.rs:4:1
        |
      4 | #![feature(int_roundings)]
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^
      
      
      error[E0554]: `#![feature]` may not be used on the stable release channel
       --> /Users/jslesar/.cargo/registry/src/github.com-1ecc6299db9ec823/argminmax-0.3.1/src/lib.rs:1:12
        |
      1 | #![feature(stdsimd)]
        |            ^^^^^^^
      
      
      error[E0554]: `#![feature]` may not be used on the stable release channel
       --> /Users/jslesar/.cargo/registry/src/github.com-1ecc6299db9ec823/argminmax-0.3.1/src/lib.rs:4:12
        |
      4 | #![feature(int_roundings)]
        |            ^^^^^^^^^^^^^
      
      
      error: aborting due to 6 previous errors
      
      
      For more information about this error, try `rustc --explain E0554`.
      
      Error: command ['maturin', 'pep517', 'build-wheel', '-i', '/Users/jslesar/projects/tsdownsample/venv/bin/python3', '--compatibility', 'off', '--editable'] returned non-zero exit status 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building editable for tsdownsample
Failed to build tsdownsample
ERROR: Could not build wheels for tsdownsample, which is required to install pyproject.toml-based projects

[jayceslesar]

In order to run python tests I needed to also pip install tsdownsample in my venv which seems sort of broken

[jvdd]

``#![feature] may not be used on the stable release channel

Is it possible that you are on the stable release, instead of the nightly release of Rust?

[jvdd]

In order to run python tests I needed to also pip install tsdownsample in my venv which seems sort of broken

Can you elaborate further on this?

[jvdd]

Looked further into it and pip install -e . requires now a setup.py - as we do not use / need a setup.py I'll change this to pip install .

[jvdd]

Closing this issue since this has been addressed in #34 & 8c4d305

Feel free to re-open if this does not fully resolve the issue!