Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Tutorial) First and last lines after Sobel filtering. #19

Open
kdesnos opened this issue Nov 28, 2019 · 0 comments
Open

(Tutorial) First and last lines after Sobel filtering. #19

kdesnos opened this issue Nov 28, 2019 · 0 comments

Comments

@kdesnos
Copy link
Member

kdesnos commented Nov 28, 2019

In the sobel tutorial, first and last line of the output image are not properly set before being displayed, which may cause variations at each code generation.

To solve the issue:

  • Sequential sobel: The sobel actor should set to black lines the first and last line of its outpit
  • Parallel sobel: in the merge actor, the first and last line of the output should be set to black lines also.

In both case, adding the following code to the actors is sufficient:

memset(output, 0, width);
memset(output + (height - 1)*width, 0, width);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant