Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version range to pypi-dependencies when using pixi add --pypi #1409

Closed
2 tasks done
FunkMonkey opened this issue May 18, 2024 · 6 comments
Closed
2 tasks done

Add version range to pypi-dependencies when using pixi add --pypi #1409

FunkMonkey opened this issue May 18, 2024 · 6 comments
Labels
🐍 pypi Issue related to PyPI dependencies ✨ enhancement Feature request

Comments

@FunkMonkey
Copy link

Checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example

pixi add EduData --pypi

Issue description

Maybe I just have the wrong expectations, but when I added a package via the --pypi flag, the package was simply added like this to pyproject.toml:
dependencies = ["edudata"]

Is this the expected behaviour or should the package be added with default version ranges as discussed in #639?

Thank you

Expected behavior

Expected dependencies:
dependencies = ["edudata >=0.0.18,<0.1"]

@FunkMonkey FunkMonkey added the 🐞 bug Something isn't working label May 18, 2024
@olivier-lacroix
Copy link
Contributor

It would make sense to be consistent between pypi and conda packages. Maybe not a bug but a enhancement?

@ruben-arts ruben-arts changed the title pixi add --pypi does not add a version range to the dependencies list Add version range to pypi-dependencies when using pixi add --pypi May 21, 2024
@ruben-arts ruben-arts added ✨ enhancement Feature request 🐍 pypi Issue related to PyPI dependencies and removed 🐞 bug Something isn't working labels May 21, 2024
@SeanPedersen
Copy link

I just want to emphasize that this "enhancment" is critical for adoption of pixi since it is needed to achieve reproducible package builds. Hope someone finds the time to tackle this one, I would but I am not experienced in Rust.

@baszalmstra
Copy link
Contributor

@ruben-arts I though this was already implemented with the latest release?

@ruben-arts
Copy link
Contributor

I thought so too but want to make sure before closing the issue.

@ruben-arts
Copy link
Contributor

This is was actually fixed already in #1508.

Closing this as fixed.

@SeanPedersen Are you trying with the latest release? If so and it still doesn't work, can you open a new issue with the non working pixi.toml/pyproject.toml?

@SeanPedersen
Copy link

Everything works as expected with the latest release, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐍 pypi Issue related to PyPI dependencies ✨ enhancement Feature request
Projects
None yet
Development

No branches or pull requests

5 participants