-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major flaw in PATH
handling of install.sh
#2188
Comments
Thanks @Arcitec - the code for Do you want to send a PR? |
Here's an example of every other software's @wolfv I was considering making a PR but I see that you support many shells, so I am not 100% comfortable doing it since I could only test Bash and ZSH. |
@wolfv I suppose I could do the Bash and ZSH parts now. |
Yes, that would already cover many users! Thank you 🙏 |
The latest version of
install.sh
creates the PATH as follows, which breaks every user's system if they have any paths with spaces:The correct method is to always, always, always double-quote:
Furthermore, you should either be resolving the
~
or replacing it with$HOME
, because~
is not valid insidePATH
. So the final code would be:The text was updated successfully, but these errors were encountered: