Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activation of global install bins are overwriting the path, affect program like pueue add #2507

Closed
2 tasks done
way-zer opened this issue Nov 19, 2024 · 5 comments
Closed
2 tasks done
Assignees
Labels
area:global Related to pixi global ✨ enhancement Feature request

Comments

@way-zer
Copy link

way-zer commented Nov 19, 2024

Checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example

pixi global install "pueue" -c dnachun -c conda-forge
pueued -d #start deamon
export PATH="TEST:$PATH" # or pixi shell in another project
pueue add env 
pueue log -f 1 | grep PATH # will get wrong PATH

Issue description

May like #133. pixi global will overwrite PATH and CONDA_PREFIX(no affect this example), so the actual execuable will get wrong PATH variable.

Maybe provide a way to expose binary without activation, and maybe use symbol link.

Expected behavior

not overwrite or just append necessary paths to PATH variable.

@Hofer-Julian
Copy link
Contributor

Thanks for the issue. We'd be open to a --no-activation option. Just haven't gotten around implementing it yet

@Hofer-Julian Hofer-Julian added ✨ enhancement Feature request area:global Related to pixi global labels Nov 19, 2024
@Hofer-Julian Hofer-Julian self-assigned this Nov 19, 2024
@wolfv
Copy link
Member

wolfv commented Nov 19, 2024

@Hofer-Julian didn't we discuss to keep the path dynamic? We could easily react to PATH changes without changing the rest of the logic

@Hofer-Julian
Copy link
Contributor

@Hofer-Julian didn't we discuss to keep the path dynamic? We could easily react to PATH changes without changing the rest of the logic

Yes, that is indeed the more elegant solution for this specific problem

@way-zer
Copy link
Author

way-zer commented Nov 20, 2024

The current implement seems break many things, like pixi global make. When use make, it even can't found binary in current PATH.

It's confusing to get this.
Image

We could easily react to PATH changes without changing the rest of the logic

dynamic PATH may be the best answer, considering the confusing problem without using --no-activation

So, this issue may be bug, instead of enhancement. (The PATH should be dynamic)

@way-zer
Copy link
Author

way-zer commented Dec 9, 2024

Seems fixed in v0.38.0

@way-zer way-zer closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:global Related to pixi global ✨ enhancement Feature request
Projects
None yet
Development

No branches or pull requests

3 participants