Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error. PHP 5.6.18 #96

Open
liuqian1990 opened this issue Jun 15, 2016 · 4 comments
Open

Compile error. PHP 5.6.18 #96

liuqian1990 opened this issue Jun 15, 2016 · 4 comments

Comments

@liuqian1990
Copy link

/home/webadm/wwwroot/xhprof_new/extension/xhprof.c: In function ‘hp_get_function_name’:
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:972: warning: assignment discards qualifiers from pointer target type
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:1042: warning: passing argument 1 of ‘hp_get_base_filename’ discards qualifiers from pointer target type
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:926: note: expected ‘char *’ but argument is of type ‘const char *’
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c: In function ‘hp_execute_internal’:
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:1741: error: ‘zend_execute_data’ has no member named ‘Ts’
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c: In function ‘hp_compile_file’:
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:1785: warning: passing argument 1 of ‘hp_get_base_filename’ discards qualifiers from pointer target type
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:926: note: expected ‘char *’ but argument is of type ‘const char *’
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c: In function ‘hp_begin’:
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:1853: error: lvalue required as left operand of assignment
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:1856: warning: assignment from incompatible pointer type
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:1861: warning: assignment from incompatible pointer type
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c: In function ‘hp_stop’:
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:1926: error: lvalue required as left operand of assignment
/home/webadm/wwwroot/xhprof_new/extension/xhprof.c:1927: warning: assignment from incompatible pointer type

@liuqian1990 liuqian1990 changed the title 编译时报错 Compile error. PHP 5.6.18 Jun 15, 2016
@aik099
Copy link
Collaborator

aik099 commented Jun 15, 2016

I guess something similar will happen for PHP 7 as well.

Have you tried compiling using original Facebook repo (from where this one is forked): https://github.com/phacility/xhprof ?

I'm not sure, but seems that only UI part (not PHP extension code) is different between these 2 repos.

@tperalta82
Copy link

Use tideways extension which is an updated xhprof
https://github.com/tideways/php-profiler-extension

and check my pull request
#97

@aik099
Copy link
Collaborator

aik099 commented Oct 9, 2016

Not sure what exactly is changed. For example since this project was originally forked from Facebook version the PHP extension was changed in a ways, that doesn't map to changes made in original Facebook XHProf project.

I bet both tideways, uprofiler and other xhprof forks also have their unique changes, that are then used in their bundled UI.

@tperalta82
Copy link

exactly, it's basically a fork with more features, but seems to keep the base ones.
the only thing that seems to be changed (From base as well) is the naming structure, instead of XHPROF_ it's TIDEWAYS_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants