Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

docker save to show tar download updates #79

Open
tiero opened this issue Jul 10, 2023 · 5 comments
Open

docker save to show tar download updates #79

tiero opened this issue Jul 10, 2023 · 5 comments
Assignees

Comments

@tiero
Copy link
Contributor

tiero commented Jul 10, 2023

Currently, the percentage doesn't reflect the real state of the download, It's a hacky solution for now.
the best approach would be to move to download the image as tar.gz via the docker save command.

We may need to check what the native SDK of Pythong allows to monitor the advancement of the file download, otherwise, we can check the file size on disk by checking polling the size.

Consider using SSE (Server Side Events to use EventSource browser API) but would be helpful to make sure that if a browser client re-connects to the same image download request, it keeps downloading in the background and return the updated progress.

@tiero
Copy link
Contributor Author

tiero commented Jul 11, 2023

This should replace the current endpoint that does not track well the download percentage

@msanjeevkumar
Copy link
Contributor

I can fix the current endpoint to track the download percentage, my implementation monitors the progress of docker pull image layers and determine the average progress of all layers currently getting downloaded

@msanjeevkumar
Copy link
Contributor

@tiero please review #82

@tiero tiero reopened this Jul 17, 2023
@tiero
Copy link
Contributor Author

tiero commented Jul 17, 2023

It turns out it's not stable enough, plus is best to keep the state of the progression

@tiero
Copy link
Contributor Author

tiero commented Oct 2, 2023

Need to re-open as it seems to not be reliable still
bit-gpt/app#357

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants