This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
docker save to show tar download updates #79
Comments
This should replace the current endpoint that does not track well the download percentage |
I can fix the current endpoint to track the download percentage, my implementation monitors the progress of docker pull image layers and determine the average progress of all layers currently getting downloaded |
It turns out it's not stable enough, plus is best to keep the state of the progression |
Need to re-open as it seems to not be reliable still |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, the percentage doesn't reflect the real state of the download, It's a hacky solution for now.
the best approach would be to move to download the image as
tar.gz
via thedocker save
command.We may need to check what the native SDK of Pythong allows to monitor the advancement of the file download, otherwise, we can check the file size on disk by checking polling the size.
Consider using SSE (Server Side Events to use
EventSource
browser API) but would be helpful to make sure that if a browser client re-connects to the same image download request, it keeps downloading in the background and return the updated progress.The text was updated successfully, but these errors were encountered: