Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New <DCompile> tags being added to every vcxproj #1097

Closed
ratzlaff opened this issue May 29, 2018 · 2 comments
Closed

New <DCompile> tags being added to every vcxproj #1097

ratzlaff opened this issue May 29, 2018 · 2 comments

Comments

@ratzlaff
Copy link
Contributor

ratzlaff commented May 29, 2018

I am updating the premake repo we are using here at my company and after running our internal regression tests, every one of our tests fail because <DCompile> has been added to every vcxproj that premake generates.

We aren't compiling any D sources, so I am a little surprised that this should be a default setting for every visual studio project.

@ratzlaff ratzlaff changed the title Unnecessary<DCompile> tags being added to generated vcxproj New <DCompile> tags being added to every vcxproj May 29, 2018
@tdesveauxPKFX
Copy link
Contributor

Yeah, I had the same issue yesterday. I just removed the d module from Premake _modules.lua before building it.

You can also override the dCompile function with this:

function m.dCompile(cfg)
	if p.config.hasFile(cfg, path.isdfile) then
		p.push('<DCompile>')
		p.callArray(m.elements.dCompile, cfg)
		p.pop('</DCompile>')
	end
end

I planned to make a PR later today to fix this.

@ratzlaff
Copy link
Contributor Author

I thought removing the module was a bit extreme. The override looks good though, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants