-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle conflicting API (in external modules)? #2184
Comments
This is tricky. You could probably override However, this won't do anything for any instances of modules overriding the same function. Especially ones that extend call arrays and perform the same checks, like this: premake-core/modules/android/vsandroid_vcxproj.lua Lines 43 to 56 in fa2405d
Pulling in another Android module that extends VS would likely result in the same kind of override being performed and both will execute and result in two entries for premake-core/modules/vstudio/vs2010_vcxproj.lua Lines 1741 to 1753 in fa2405d
So, while you might be able to avoid the situation of two modules adding the same API and causing an error, you won't be able to avoid the situation of two modules extending the same function. The only way to truly do that is to not load both of them together. |
What's your question?
I test external modules, I put generators in premake5-system.lua
I have one project which uses one module with "conflicting" api
same name, (and even same definition) leading to errors.
Which is the proper way to handle that?
For actual case, it is premake-qt and premake-qmake with api
qtmodules
.Anything else we should know?
From dcourtois/premake-qt#33
The text was updated successfully, but these errors were encountered: