Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push/pop/shift/unshift methods #1

Open
assertchris opened this issue May 22, 2017 · 1 comment
Open

Add push/pop/shift/unshift methods #1

assertchris opened this issue May 22, 2017 · 1 comment

Comments

@assertchris
Copy link
Member

No description provided.

@p810
Copy link

p810 commented Sep 4, 2019

I've created a pull request for this (#7 ), but I wanted to ask whether you think these methods should mutate the collection, or if they should return a new instance. I'm happy to update them if the latter, I just couldn't tell whether they should be because, while most of the other methods return new instances, their counterparts in the standard lib do as well, e.g. array_filter() to Collection::filter().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants