-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Support: Checkstyle #2342
Comments
I think the latter (.gitattributes) would be a better solution. @electrum WDYT? |
@kadaan, the repository doesn't contain source files with \r\n. If your git client creates such line endings upon checkout, it's a matter of your git client's configuration. Did you set |
Setting core.autocrlf to false bypassed the fail with maven-checkstyle-plugin issue in windows. |
@blackhawkbigpunch thanks for sharing this |
Presto fails to build on Windows due to checkstyle enforcing that lines end in \n. This is not the line separator in windows. Can the checkstyle checks be changed to allow any of: \r\n, \n, \r? Alternately, can a .gitattributes file be added which specifies that LF is the correct newline character by: text eol=lf
The text was updated successfully, but these errors were encountered: