Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Support: AlignedTablePrinter and VerticalRecordPrinter in Presto-Cli should support platform specific newline characters #2442

Closed
kadaan opened this issue Feb 27, 2015 · 2 comments
Closed

Windows Support: AlignedTablePrinter and VerticalRecordPrinter in Presto-Cli should support platform specific newline characters #2442

kadaan opened this issue Feb 27, 2015 · 2 comments

Comments

@kadaan
Copy link

kadaan commented Feb 27, 2015

The AlignedTablePrinter and VerticalRecordPrinter in Presto-Cli assume that all newlines are \n. This should be updated to support Windows newline characters: \r\n. LINE_SPLITTER, HEX_LINE_JOINER, and all emitted newlines should be changed to support the newline characters of all platforms.
@kadaan kadaan mentioned this issue Feb 27, 2015
Closed
12 tasks
@kokosing
Copy link
Contributor

kokosing commented Jul 5, 2018

Closing this because parent task closed #2351

@kokosing kokosing closed this as completed Jul 5, 2018
@kokosing
Copy link
Contributor

kokosing commented Jul 5, 2018

Actually, this one could be implemented. However, I haven't heard about anyone having any issue with presto-cli on Windows. Let's reopen this if such an issue occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kadaan @kokosing