Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextCommand_WAIT_BUTTON naming #1109

Open
mauvesea opened this issue Feb 4, 2024 · 2 comments
Open

TextCommand_WAIT_BUTTON naming #1109

mauvesea opened this issue Feb 4, 2024 · 2 comments
Labels

Comments

@mauvesea
Copy link

mauvesea commented Feb 4, 2024

The comment for the function TextCommand_WAIT_BUTTON suggests the arrow shouldn't be printed, but it calls PromptButton, which prints the arrow.

I believe that command itself is never used, so the issue goes unseen in regular gameplay. The fix to that is just to call WaitButton instead. (Thanks @Idain !)

@starleaf-luna
Copy link

are we sure it was meant to call waitbutton, not promptbutton? are we sure the comment is right?

@Idain
Copy link
Contributor

Idain commented Feb 4, 2024

There's already a TextCommand_PROMPT_BUTTON which works perfectly, and the one mentioned in this issue isn't a copy of the first, so there's a good chance it's a bug.

Another chance is that whoever named the function wrongly called it WAIT_BUTTON and not PROMPT_BUTTON_2, but considering most text commands have an equivalent TextCommand_*, this possibility is low.

@Rangi42 Rangi42 changed the title TextCommand_WAIT_BUTTON bug TextCommand_WAIT_BUTTON naming Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants