Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: contains_valid_token #64

Open
alexcouper opened this issue Aug 19, 2014 · 2 comments
Open

Security: contains_valid_token #64

alexcouper opened this issue Aug 19, 2014 · 2 comments

Comments

@alexcouper
Copy link
Member

For now this is fine, but we should remember that this is subject to a man in the middle attack because the headers can be reused to make subsequent requests "as" the original client.

@txels
Copy link
Member

txels commented Aug 19, 2014

Good point. Well, this should be secure enough under HTTPS (same premise as HTTP basic authentication).

Do you have any specific idea in mind for a more secure approach?

@alexcouper
Copy link
Member Author

Possibly S3-style signing of requests?

But you're right about https - that should take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants